Template issues after upgrade to 7.10

Today I started to upgrade our old 7.7.8 V to 7.10 V. I did the procedure slowly, upgrading version by version 7.7.8->7.8->7.9->7.10.
After finishing the upgrade I started to check that everything was working fine.

Some minor issues appeared but most of them repaired with a “Quick Repair & Rebuild” except 3.
(use the color for reference to the image below)

  1. (RED) ALL the DD menus are transparent.
  2. (GREEN) The clear button of the DDs moved below.
  3. (BLUE) The mandatory red asterisk moved below the label text.

Thank you advance

I do not know that, but …
I tried to upgrade v.7.8.15 and also 7.9.14 to 7.10 and none looked good.
I see many people in the forum with upgrade issues. I did a clean install immediately and now everything works.
Sounds like the best way.

In my case after every upgrade there were some issues, but I always managed to fix them. Now I’m stuck.
Clean install DOESN’T sound like the best way, 'cause my installation has been heavily modified.

@erevodifosin sorry to hear you’re having troubles… I still lhaven’t figured out what this upgrader bug is.

Please run this command to get a file with your current permissions:

tree -iudpf cache/themes > perms1.txt

Then fix your permissions on the cache/themes directory to 775.

Then run the command again to a different file:

tree -iudpf cache/themes > perms2.txt

Now, is anything looking better? If so, we can then examine those files for difference and try to understand what’s breaking. Thanks

@pgr thank you for your answer.
The 2 files are identical. Permission issue was the first thing came to my mind too.

cache/themes
[drwxrwsr-x apache  ]  cache/themes/Suite7
[drwxrwsr-x apache  ]  cache/themes/SuiteP
[drwxrwsr-x apache  ]  cache/themes/SuiteR
[drwxrwsr-x apache  ]  cache/themes/SuiteR/css
[drwxrwsr-x apache  ]  cache/themes/SuiteR/js
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/Accounts
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AMC_Positions
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AMC_Rep_Projects
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AMC_Spare_Parts
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AMC_Vessels
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AMC_Visits
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/AOR_Reports
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/Contacts
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/Documents
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/Notes
[drwxrwsr-x apache  ]  cache/themes/SuiteR/modules/Tasks

I see you’re using SuiteR, not SuiteP… I thought this problem was only with SuiteP (because of the new sub-themes).

And your permissions look ok…

Do you see any errors on the browser console, network tab? Like being unable to load some CSS file?

My apologies i run the tree command on the production system. Below is the dev system with the issue.
The console displayes this “Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user’s experience. For more help http://xhr.spec.whatwg.org/ sugar_grp1_yui.js:16:3050” but not in the edit view.

[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Dawn
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Day
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/js
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/AMC_Vessels
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Tasks
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Users

What if you remove the “d” switch from the tree command, to make it show also files? Do you see anything suspicious then?

I think no. The only difference is at the file modules/AMC_Vessels/EditView.tpl but I don’t think so this is the issue.
This is a custom module of mine but the issue exists on every DropDown menu.

[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Dawn
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Dawn/style.css
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Day
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/css/Day/style.css
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/js
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/js/style-min.js
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts/DetailView.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts/EditView.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts/SearchForm_advanced.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts/SearchFormFooter.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Accounts/SearchFormHeader.tpl
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/AMC_Vessels
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/AMC_Vessels/DetailView.tpl
[-rwxr-xr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/AMC_Vessels/EditView.tpl
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Tasks
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Tasks/SearchForm_sps.tpl
[drwxrwsr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Users
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Users/DetailView.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/modules/Users/EditView.tpl
[-rwxrwxr-x apache  ]  /var/www/html/suitecrm_dev/cache/themes/SuiteP/pathCache.php

Have you tried deleting cache/themes? It will get recreated.

Yep with no luck.

And the other rebuilds from Admin / Repair?

Javascript stuff

The below is a screenshot from the online demo 7.10. Comparing with mine, it looks like that my installation hasn’t been fully upgraded to SuiteP.

Any errors in upgradeWizard.log?

Repair JS - No
UpgradeWizard.log - No errors!

I thought to run a new install and compare files

Fresh install completed.
I opened both installation side-by-side and noticed the below.

Also i found these in the php error log, don’t know if they are related. All of them caused by upgraded 7.10
Line 16919: [Mon Mar 05 16:30:10.281837 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldVarchar::displayInput(&$layout_def) should be compatible with SugarWidgetField::displayInput($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?action=ajaxui
Line 16920: [Mon Mar 05 16:30:10.281915 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldName::queryFilterone_of($layout_def, $rename_columns = true) should be compatible with SugarWidgetFieldVarchar::queryFilterone_of(&$layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?action=ajaxui
Line 16921: [Mon Mar 05 16:30:10.281933 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldName::displayList(&$layout_def) should be compatible with SugarWidgetField::displayList($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?action=ajaxui
Line 16922: [Mon Mar 05 16:30:10.282281 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldId::queryFilterIs(&$layout_def) should be compatible with SugarWidgetReportField::queryFilterIs($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldid.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?action=ajaxui
Line 16923: [Mon Mar 05 16:30:11.864537 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldVarchar::displayInput(&$layout_def) should be compatible with SugarWidgetField::displayInput($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 16924: [Mon Mar 05 16:30:11.864594 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldName::queryFilterone_of($layout_def, $rename_columns = true) should be compatible with SugarWidgetFieldVarchar::queryFilterone_of(&$layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 16925: [Mon Mar 05 16:30:11.864611 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldName::displayList(&$layout_def) should be compatible with SugarWidgetField::displayList($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 16926: [Mon Mar 05 16:30:11.864763 2018] [:error] [pid 27463] [client 172.31.250.64:50080] PHP Warning: Declaration of SugarWidgetFieldId::queryFilterIs(&$layout_def) should be compatible with SugarWidgetReportField::queryFilterIs($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldid.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 17065: [Mon Mar 05 16:33:06.519924 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldVarchar::displayInput(&$layout_def) should be compatible with SugarWidgetField::displayInput($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17066: [Mon Mar 05 16:33:06.519947 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldName::queryFilterone_of($layout_def, $rename_columns = true) should be compatible with SugarWidgetFieldVarchar::queryFilterone_of(&$layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17067: [Mon Mar 05 16:33:06.519955 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldName::displayList(&$layout_def) should be compatible with SugarWidgetField::displayList($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17068: [Mon Mar 05 16:33:06.520013 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldId::queryFilterIs(&$layout_def) should be compatible with SugarWidgetReportField::queryFilterIs($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldid.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17069: [Mon Mar 05 16:33:07.143024 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldVarchar::displayInput(&$layout_def) should be compatible with SugarWidgetField::displayInput($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldvarchar.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 17070: [Mon Mar 05 16:33:07.143094 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldName::queryFilterone_of($layout_def, $rename_columns = true) should be compatible with SugarWidgetFieldVarchar::queryFilterone_of(&$layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 17071: [Mon Mar 05 16:33:07.143125 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldName::displayList(&$layout_def) should be compatible with SugarWidgetField::displayList($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldname.php on line 46, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 17072: [Mon Mar 05 16:33:07.143249 2018] [:error] [pid 27434] [client 172.31.250.64:50113] PHP Warning: Declaration of SugarWidgetFieldId::queryFilterIs(&$layout_def) should be compatible with SugarWidgetReportField::queryFilterIs($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetFieldid.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Home&action=index
Line 17874: [Mon Mar 05 17:18:38.398843 2018] [:error] [pid 37082] [client 172.31.250.64:51047] PHP Warning: Declaration of SugarWidgetSubPanelEditSecurityGroupUserButton::displayDetail($layout_def) should be compatible with & SugarWidgetField::displayDetail($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetSubPanelEditSecurityGroupUserButton.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17875: [Mon Mar 05 17:18:38.398875 2018] [:error] [pid 37082] [client 172.31.250.64:51047] PHP Warning: Declaration of SugarWidgetSubPanelEditSecurityGroupUserButton::displayHeaderCell(&$layout_def) should be compatible with SugarWidgetField::displayHeaderCell($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetSubPanelEditSecurityGroupUserButton.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1
Line 17876: [Mon Mar 05 17:18:38.398886 2018] [:error] [pid 37082] [client 172.31.250.64:51047] PHP Warning: Declaration of SugarWidgetSubPanelEditSecurityGroupUserButton::displayList(&$layout_def) should be compatible with SugarWidgetField::displayList($layout_def) in /var/www/html/suitecrm_dev/include/generic/SugarWidgets/SugarWidgetSubPanelEditSecurityGroupUserButton.php on line 0, referer: http://172.31.250.18/suitecrm_dev/index.php?module=Users&action=EditView&record=1

Let’s try and fix those PHP errors to see if it makes a difference, see this

https://github.com/salesagility/SuiteCRM/issues/5303

and the fix here

https://github.com/salesagility/SuiteCRM/pull/5336

please see if that improves anything.

First I did the upgrade to 7.10.1.
Second I used the github links you sent as a reference to fix the errors in my logs.
Now the upgraded 7.10 -> 7.10.1 screenshot from the admin profile.

And also found these in the suitecrm.log file after the upgrade

Tue Mar  6 10:22:29 2018 [51390][1][FATAL]  Query Failed:  ALTER TABLE email_addresses ADD confirm_opt_in VARCHAR(255) DEFAULT 'opt-in' NULL: MySQL error 1060: Duplicate column name 'confirm_opt_in'
Tue Mar  6 10:25:26 2018 [51244][1][FATAL] field_defs should be an array
Tue Mar  6 10:25:52 2018 [51256][1][FATAL] field_defs should be an array
Tue Mar  6 10:30:41 2018 [28286][1][FATAL] Error: File [modules/EmailAddresses/metadata/detailviewdefs.php] is missing. Unable to create because no corresponding HTML file was found.
Tue Mar  6 10:32:13 2018 [51503][1][FATAL] Error: File [modules/EmailAddresses/metadata/detailviewdefs.php] is missing. Unable to create because no corresponding HTML file was found.
Tue Mar  6 10:43:47 2018 [37124][1][FATAL] field_defs should be an array
Tue Mar  6 11:40:32 2018 [51244][1][FATAL] field_defs should be an array
Tue Mar  6 11:46:55 2018 [58921][1][FATAL] field_defs should be an array
Tue Mar  6 11:46:57 2018 [58921][1][FATAL] field_defs should be an array
Tue Mar  6 11:47:10 2018 [58921][1][FATAL] field_defs should be an array
Tue Mar  6 11:47:15 2018 [58921][1][FATAL] field_defs should be an array

This is my favorite thread for the 7.10 upgrader bugs since you are a competent sysadmin on a self-hosted system - I have too many threads with non-technical users on shared-hostings, those are very hard to troubleshoot consistently… so thank you.

Ok so a few questions:

  1. I noticed the fixes on the PR above didn’t cover all the functions with that “&$layout” parameter. Did you change just the ones on that PT, or all of them, including the ones that were giving errors on your system?

  2. Did your upgrade complete without errors in the logs? Please check install.log for the fresh install and upgradeWizard.log for the upgrade.

  3. The “field_defs should be an array” and the email_addresses errors are already on GitHub, I’ve seen them before. They might have fixes there already, and if not, they will surely be worked on this week.

  4. About the duplicate column: if you do a QR&R and scroll down to the bottom, does it mention database and vardefs are out-of-sync? Press the button to fix, if there is one.

I should thank you! :slight_smile:

  1. First i checked the functions mentioned in the github, than those mentioned in the logs.

  2. I did the 7.10.1 upgrade only on the 7.7.8->7.10 upgraded version. Not the freshly installed 7.10. Check the UpgradeWizard.log HERE

3)When I did the 7.7.8->7.10 upgrade, the emails in Accounts and Contacts didn’t work, problem solved with a QR&R.

4)I run the QR&R twice and I got the same mismatch below. I clicked on the execute button both times. I don’t see any oauth2clients table in DB.

/* Table : oauth2clients */
/*COLUMNS*/
/*MISMATCH WITH DATABASE - duration_value -  ROW [name] => 'duration_value'  [type] => 'int'  [len] => '11'  */
/* VARDEF - duration_value -  ROW[name] => 'duration_value'  [type] => 'integer'  [required] => ''  [reportable] => ''  [api-visible] => ''  [inline_edit] => ''  [dbType] => 'integer'  [len] => ''  */
/*MISMATCH WITH DATABASE - duration_amount -  ROW [name] => 'duration_amount'  [type] => 'int'  [len] => '11'  */
/* VARDEF - duration_amount -  ROW[name] => 'duration_amount'  [vname] => 'LBL_DURATION_AMOUNT'  [type] => 'integer'  [required] => ''  [reportable] => ''  [api-visible] => ''  [inline_edit] => ''  [dbType] => 'integer'  [len] => ''  */
/* INDEXES */
ALTER TABLE oauth2clients   modify COLUMN duration_value integer  NULL ,  modify COLUMN duration_amount integer  NULL ;