Hi,
I am new to contributing code to SuiteCRM.
I have fixed a couple of bugs and followed the steps of contribution by opening the pull request -
https://github.com/salesagility/SuiteCRM/pull/8254
The travis check seems to be stuck for the last day. Is my expectation of the tests being run within a day wrong?
Please let me know.
thanks,
Also, is there a way to check why travis is waiting or some kind of status on the same? Some logs… something at all?
Hmm, odd. You might want to just try to close the PR and open a new one? I’ve seen Travis do that before and I haven’t figured out a fix for it, nor do I really know why it does that sometimes. Generally, what should happen is that the status at the bottom of the PR would have a yellow dot next to it when Travis receives it, which should happen within a minute of the PR being opened. If it doesn’t have that dot, it hasn’t received it yet. I’m honestly not really sure why that’d be, it doesn’t look like Travis is having any downtime atm.
You can see the recent PRs here: https://travis-ci.org/salesagility/SuiteCRM/pull_requests
If there’s a bunch of yellow builds in that PR list, then it’ll probably take an hour or a few hours for any new PRs to get run. When I’m posting this right now, all the PR builds have finished.
Also, for what it’s worth you should generally open PRs against hotfix-7.10.x rather than hotfix. The only exceptions are for major breaking changes (those go into develop) and for fixes/changes that are only relevant to 7.11.x, e.g. stuff related to ElasticSearch.
Thank you for responding, connorshea. Will open a new PR.
About opening the PRs against hotfix-7.10.x vs hotfix, the bug was introduced in 7.11.6 or more and so is a problem only for 7.11.xx branch. According to the documentation available at https://github.com/salesagility/SuiteCRM/blob/master/.github/CONTRIBUTING.md, I see that if it only affects, 7.11.xx, we need to open the PR against hotfix branch.
It would be great if you explain, what are the important points to decide the branch against which we need to open the PRs.
thanks.
Well, it seems like hotfix-7.10.x is the right branch against which I need to create the PR. After I did that, I see the Travis has picked up.
Thanks @connorshea
I have created the pull request - https://github.com/salesagility/SuiteCRM/pull/8264 for the bug fix.
Its been sitting there for 23 days now and no movement. Should I be doing something to bring this to notice to the people who are managing the repo?
Hey @iamamoron42
Just want to thank you for the contribution!
Regards to raising it to our attention we try and get round to all the PRs asap but if you mention us on the PR itself then the SuiteCRM team get’s a notification @suitecrm-core <-- that’s the team on the repo that get these notifications. A note to add is that PRs don’t get merged in automatically and require a human to assess & code review but the team will update the PR accordingly. 