Attachments - Corrupted Files

SuiteCRM Forum - English Language SuiteCRM Outlook Plugin
1

Hi there, i noticed that sending emails from Outlook 2007 with attachments, creates notes in right way but only text file are correctly downloadable.

Jpg images or PDF files are corrupted.

See images-31.jpg (right image) and images-31 (1).jpg (corrupted one)

2

Thank you for highlighting this. We will investigate, test and push out a fix for this bug.

Thanks,

Will.

1 Like
3

Sorry to resurrect an old thread but was a patch for this ever pushed? We are experiencing the same issues, again with Outlook 2007.

Thanks,

Sam

4

Hi Sam,

There was no updated outlook plugin released as yet, but we plan to release this soon and I will update the thread once released.

Thanks,

Will.

5

Sorry to beat a dead horse Will, I couldn’t see the issue on Git and was wondering if it had only been reported for 2007 or was known to occur in other versions, I would just like to know that if I recommend my clients move to a later version of Outlook the problem is unlikely to persist.

Thanks again for your time.

6

Hello, this issue occurs because plugin base64 encodes attachements with spaces instead of “+”.
for example:

“asdklhgisjkhfo asdpjadhsi aidhsiasuhd”

It should be:

“asdklhgisjkhfo+asdpjadhsi+aidhsiasuhd”

PHP base64_decode then missreads string with spaces.

Workaraound in SuiteCRM: go to modules/notes/NoteSoap.php find

if(!empty($note['file'])){

add after:

$note['file'] = str_replace(" ",'+', $note['file']);
2 Likes
7

Going to try this first thing tomorrow, just wanted to say thanks in advance, if this is the fix I have been looking for I owe you big time. :cheer:

8

No problem, tell me if it worked. :slight_smile:

9

Does not appear to have worked unfortunately, I will look into this more thoroughly in the future though. Thanks.

10

Worked for me when I changed to the following;

$note[‘file’] = str_replace(’ ‘,’+’, $note[‘file’]);

in both functions;

saveFile()
newSaveFile()

Thanks Axe.

11

Should have been;

$note['file'] =  str_replace(' ','+', $note['file']);

cut n paste did something

12

After Tien reported back with success I went and had a look and we found an issue with our server config, sorted it, re-implemented the fix and it all appears to be working, thanks a lot.

Might be worthwhile making sure someone from the Suite team sees this and the fix is shipped with the next patch.

Thanks again, this is a life saver.

13

Have the same problem: attachments corrupted
Can I download the correct version (patch) or can somebody give me info what I must change in which files on sugar files

THANKS !!

14

Hi guys,

Can i please confirm the exact change I need to make in the NoteSoap.php file?

The standard code reads -

    if(!empty($note['id'])){
            $focus->retrieve($note['id']);
            if(empty($focus->id)) {
                return '-1';
            }

Do i need to change it to read -

    if(!empty($note['file'] =  str_replace(' ','+', $note['file']);
            $focus->retrieve($note['id']);
            if(empty($focus->id)) {
                return '-1';
            }

If not, can someone please confirm the correct code?

Finally, does the correct code need to be entered onto lines 62 (function saveFile) and 100 (function newSaveFile) only?

Thanks,

Ray.

15

Hi Tien,

Can you please clarify the exact code we need to use and on which lines of the standard NoteSoap.php file?

16

Axe, hoping you could provide some guidance to the questions I posted a couple of days ago?

17

THIS WORKED FOR ME !!

modules/notes/NoteSoap.php find string:
if(!empty($note[‘file’])){
add after that:

$note[‘file’] = str_replace(’ ‘,’+’, $note[‘file’]);

Apply in both functions:

saveFile()
newSaveFile()

18

Can you please confirm if you used the following text - " if(!empty($note[‘file’])){$note[‘file’] = str_replace(’ ‘,’+’, $note[‘file’]); "?
or did you use " if(!empty($note[‘file’] = str_replace(’ ‘,’+’, $note[‘file’]); "?
Thanks

19

modules/notes/NoteSoap.php:

20

Hi Axe, I believe I have made the correct changes to my notesoap.php file but the attachments are still not copying across into Suite. Are you able to check the attached file and confirm that my changes are in fact correct?
Thanks